[GitHub] [spark] karuppayya commented on a change in pull request #28804: [SPARK-31973][SQL] Skip partial aggregates if grouping keys have high cardinality

karuppayya commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r468725811 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -838,13 +880,17 @@ case class HashAggrega

[GitHub] [spark] karuppayya commented on a change in pull request #28804: [SPARK-31973][SQL] Skip partial aggregates if grouping keys have high cardinality

karuppayya commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r467173370 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala ## @@ -353,4 +353,8 @@ object AggUtils { finalAnd

[GitHub] [spark] karuppayya commented on a change in pull request #28804: [SPARK-31973][SQL] Skip partial aggregates if grouping keys have high cardinality

karuppayya commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r467175169 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -680,6 +688,16 @@ case class HashAggregat

[GitHub] [spark] karuppayya commented on a change in pull request #28804: [SPARK-31973][SQL] Skip partial aggregates if grouping keys have high cardinality

karuppayya commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r467173370 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala ## @@ -353,4 +353,8 @@ object AggUtils { finalAnd

[GitHub] [spark] karuppayya commented on a change in pull request #28804: [SPARK-31973][SQL] Skip partial aggregates if grouping keys have high cardinality

karuppayya commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r467172474 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -680,6 +688,16 @@ case class HashAggregat

[GitHub] [spark] karuppayya commented on a change in pull request #28804: [SPARK-31973][SQL] Skip partial aggregates if grouping keys have high cardinality

karuppayya commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r467171812 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -409,6 +411,12 @@ case class HashAggregat

[GitHub] [spark] karuppayya commented on a change in pull request #28804: [SPARK-31973][SQL] Skip partial aggregates if grouping keys have high cardinality

karuppayya commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r467172000 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala ## @@ -353,4 +353,8 @@ object AggUtils { finalAnd