[GitHub] [spark] kiszk commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-25 Thread GitBox
kiszk commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-733582819 LGTM from code generation perstpective @maropu @cloud-fan @HyukjinKwon @ueshin Any other comments? In particular, regarding the specification of the function

[GitHub] [spark] kiszk commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-20 Thread GitBox
kiszk commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-731176834 Could you please add more complex test cases using `ArrayType(BinaryType)` in addition to `ArrayType(IntegerType)`? And, could you please add test cases regarding [what you

[GitHub] [spark] kiszk commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-20 Thread GitBox
kiszk commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-731023308 Sorry for late reply. I will look at this tomorrow. This is an automated message from the Apache Git Service. To

[GitHub] [spark] kiszk commented on pull request #30243: [SPARK-33335][SQL] Support `array_contains_array` func

2020-11-17 Thread GitBox
kiszk commented on pull request #30243: URL: https://github.com/apache/spark/pull/30243#issuecomment-729443301 When I only read the first description, the behavior is unknown regarding what `contains_array` mean like the following cases - `array_contains_array(array(1, 2, 3), array(3,