[GitHub] [spark] kudhru commented on pull request #32907: [SPARK-35757][CORE] Add bitwise AND operation and functionality for intersecting bloom filters

2021-06-15 Thread GitBox
kudhru commented on pull request #32907: URL: https://github.com/apache/spark/pull/32907#issuecomment-861695720 > The implementation here seems to be obviously looking correct, but could we add some unit test for it? (e.g. in `BloomFilterSuite.scala`) > Added a test as suggested.

[GitHub] [spark] kudhru commented on pull request #32907: [SPARK-35757][CORE] Add bitwise AND operation and functionality for intersecting bloom filters

2021-06-15 Thread GitBox
kudhru commented on pull request #32907: URL: https://github.com/apache/spark/pull/32907#issuecomment-862048748 I am a bit confused as to how and when will this PR be merged into the master branch. Could someone please clarify? -- This is an automated message from the Apache Git Service.

[GitHub] [spark] kudhru commented on pull request #32907: [SPARK-35757][CORE] Add bitwise AND operation and functionality for intersecting bloom filters

2021-06-16 Thread GitBox
kudhru commented on pull request #32907: URL: https://github.com/apache/spark/pull/32907#issuecomment-862144672 Could anyone tell how to fix the failing **MiMa** tests? ``` [error] spark-sketch: Failed binary compatibility check against org.apache.spark:spark-sketch_2.12:3.0.0! Found