[GitHub] [spark] manuzhang commented on pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

2022-06-13 Thread GitBox
manuzhang commented on PR #36698: URL: https://github.com/apache/spark/pull/36698#issuecomment-1153901847 Could you help review if I submitted a PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] manuzhang commented on pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

2022-06-12 Thread GitBox
manuzhang commented on PR #36698: URL: https://github.com/apache/spark/pull/36698#issuecomment-1153543507 @cloud-fan do we plan to back-port it to branch-3.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [spark] manuzhang commented on pull request #36698: [SPARK-39316][SQL] Merge PromotePrecision and CheckOverflow into decimal binary arithmetic

2022-05-30 Thread GitBox
manuzhang commented on PR #36698: URL: https://github.com/apache/spark/pull/36698#issuecomment-1140775164 Besides the bug fix test in `union.sql`, we'd better test all the `DecimalArithmetic` types. I don't think they've been covered before. -- This is an automated message from the Apache