maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r418429216
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Found
maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r418401753
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Found
maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r417036436
##
File path: sql/core/src/test/resources/sql-functions/sql-expression-schema.md
##
@@ -0,0 +1,337 @@
+## Summary
Review comment:
One more comment:
maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r416998246
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Found
maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r416999108
##
File path: sql/core/src/test/resources/sql-functions/sql-expression-schema.md
##
@@ -0,0 +1,337 @@
+## Summary
Review comment:
How about making
maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r416998246
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Found
maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r416997034
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Found
maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r416502297
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Found
maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r416227468
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Found
maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r411131675
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Found
maropu commented on a change in pull request #28194:
URL: https://github.com/apache/spark/pull/28194#discussion_r411131393
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala
##
@@ -0,0 +1,230 @@
+/*
+ * Licensed to the Apache Software Found
11 matches
Mail list logo