maropu commented on a change in pull request #29672:
URL: https://github.com/apache/spark/pull/29672#discussion_r486071663
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2560,6 +2560,33 @@ abstract class SQLQuerySuiteBase extends QueryTest with
SQLTestUtils with TestHi
}
}
}
+
+ test("SPARK-32818: make metastore convert session level configurable") {
Review comment:
Does this test fail w/o this patch? Looks it can pass even in master.
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2560,6 +2560,33 @@ abstract class SQLQuerySuiteBase extends QueryTest with
SQLTestUtils with TestHi
}
}
}
+
+ test("SPARK-32818: make metastore convert session level configurable") {
+ withSQLConf(HiveUtils.CONVERT_METASTORE_ORC.key -> "true") {
+ withTable("t") {
+ sql("CREATE TABLE t (i INT) PARTITIONED BY (p STRING) STORED AS ORC")
+ sql("INSERT INTO t PARTITION(p='20200901') SELECT 1")
Review comment:
I think we don't need the partition definition for this test and how
about writing it like this;
```
sql("CREATE TABLE t (i INT) USING hive")
sql("SELECT * FROM t")
```
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -33,7 +33,7 @@ import
org.apache.spark.sql.catalyst.analysis.{EliminateSubqueryAliases, Functio
import org.apache.spark.sql.catalyst.catalog.{CatalogTableType, CatalogUtils,
HiveTableRelation}
import org.apache.spark.sql.catalyst.parser.ParseException
import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, SubqueryAlias}
-import org.apache.spark.sql.execution.TestUncaughtExceptionHandler
+import org.apache.spark.sql.execution.{FileSourceScanExec, SparkPlan,
TestUncaughtExceptionHandler}
Review comment:
nit: `SparkPlan` not used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
