[GitHub] [spark] maropu commented on a change in pull request #29695: [SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2020-10-01 Thread GitBox
maropu commented on a change in pull request #29695: URL: https://github.com/apache/spark/pull/29695#discussion_r498593284 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -643,6 +647,34 @@ object DataSourceStrateg

[GitHub] [spark] maropu commented on a change in pull request #29695: [SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2020-09-30 Thread GitBox
maropu commented on a change in pull request #29695: URL: https://github.com/apache/spark/pull/29695#discussion_r498011378 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/sources/aggregates.scala ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [spark] maropu commented on a change in pull request #29695: [SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2020-09-30 Thread GitBox
maropu commented on a change in pull request #29695: URL: https://github.com/apache/spark/pull/29695#discussion_r497911856 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -643,6 +647,34 @@ object DataSourceStrateg

[GitHub] [spark] maropu commented on a change in pull request #29695: [SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2020-09-30 Thread GitBox
maropu commented on a change in pull request #29695: URL: https://github.com/apache/spark/pull/29695#discussion_r497921683 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -643,6 +647,34 @@ object DataSourceStrateg

[GitHub] [spark] maropu commented on a change in pull request #29695: [SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2020-09-30 Thread GitBox
maropu commented on a change in pull request #29695: URL: https://github.com/apache/spark/pull/29695#discussion_r497911856 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -643,6 +647,34 @@ object DataSourceStrateg

[GitHub] [spark] maropu commented on a change in pull request #29695: [SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2020-09-30 Thread GitBox
maropu commented on a change in pull request #29695: URL: https://github.com/apache/spark/pull/29695#discussion_r497911856 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -643,6 +647,34 @@ object DataSourceStrateg

[GitHub] [spark] maropu commented on a change in pull request #29695: [SPARK-32833][SQL] [WIP]JDBC V2 Datasource aggregate push down

2020-09-29 Thread GitBox
maropu commented on a change in pull request #29695: URL: https://github.com/apache/spark/pull/29695#discussion_r496713408 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ## @@ -643,6 +647,34 @@ object DataSourceStrateg