[GitHub] [spark] maropu commented on a change in pull request #30144: [SPARK-33229][SQL] Support GROUP BY use Separate columns and CUBE/ROLLUP

maropu commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r604635816 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -212,3 +212,29 @@ object GroupingID { if (SQ

[GitHub] [spark] maropu commented on a change in pull request #30144: [SPARK-33229][SQL] Support GROUP BY use Separate columns and CUBE/ROLLUP

maropu commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r604634949 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -212,3 +212,29 @@ object GroupingID { if (SQ

[GitHub] [spark] maropu commented on a change in pull request #30144: [SPARK-33229][SQL]Support GROUP BY use Separate columns and CUBE/ROLLUP

maropu commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r511755095 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -151,3 +151,26 @@ object GroupingID { if (SQ

[GitHub] [spark] maropu commented on a change in pull request #30144: [SPARK-33229][SQL]Support GROUP BY use Separate columns and CUBE/ROLLUP

maropu commented on a change in pull request #30144: URL: https://github.com/apache/spark/pull/30144#discussion_r511753662 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3691,6 +3691,26 @@ class SQLQuerySuite extends QueryTest with Shared