[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-24 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r529480121 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -587,13 +587,24 @@ fromClause ;

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-06 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518743354 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -79,6 +79,29 @@ case class Cube(groupByExprs:

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-06 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518742856 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -587,13 +587,26 @@ fromClause ;

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-06 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518599062 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -79,6 +79,29 @@ case class Cube(groupByExprs:

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-06 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518595373 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -587,13 +587,26 @@ fromClause ;

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-06 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518595373 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -587,13 +587,26 @@ fromClause ;

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-06 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518595373 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -587,13 +587,26 @@ fromClause ;

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-06 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518587473 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -79,6 +79,29 @@ case class Cube(groupByExprs:

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-06 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518583118 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala ## @@ -79,6 +79,29 @@ case class Cube(groupByExprs:

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-06 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518580769 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-analytics.sql ## @@ -60,3 +62,4 @@ SELECT course, year FROM courseSales GROUP BY

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-06 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518580615 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-analytics.sql ## @@ -18,9 +18,11 @@ AS courseSales(course, year, earnings); -- ROLLUP

[GitHub] [spark] maropu commented on a change in pull request #30212: [SPARK-33308][SQL] Support CUBE(...) and ROLLUP(...), GROUPING SETS(...) as group by expr in parser level

2020-11-05 Thread GitBox
maropu commented on a change in pull request #30212: URL: https://github.com/apache/spark/pull/30212#discussion_r518576347 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -587,13 +587,26 @@ fromClause ;