[GitHub] [spark] maropu commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-17 Thread GitBox
maropu commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r578037055 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercionSuite.scala ## @@ -0,0 +1,1402 @@ +/* + * Licensed to the

[GitHub] [spark] maropu commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-09 Thread GitBox
maropu commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r573368092 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercionSuite.scala ## @@ -0,0 +1,1371 @@ +/* + * Licensed to the

[GitHub] [spark] maropu commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-05 Thread GitBox
maropu commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r570661910 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apach

[GitHub] [spark] maropu commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-04 Thread GitBox
maropu commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r570674377 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apach

[GitHub] [spark] maropu commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-02-04 Thread GitBox
maropu commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r570661910 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala ## @@ -0,0 +1,316 @@ +/* + * Licensed to the Apach

[GitHub] [spark] maropu commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-01-29 Thread GitBox
maropu commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r566891204 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/text.sql.out ## @@ -54,35 +54,37 @@ struct -- !query select length(42) -- !query

[GitHub] [spark] maropu commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-01-27 Thread GitBox
maropu commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r565765354 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -31,126 +31,28 @@ import org.apache.spark.sql.ca

[GitHub] [spark] maropu commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-01-27 Thread GitBox
maropu commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r565757032 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala ## @@ -0,0 +1,305 @@ +/* + * Licensed to the Apach