[GitHub] [spark] maropu commented on a change in pull request #33212: [SPARK-35912][SQL] Fix nullability of `spark.read.json`

2021-07-16 Thread GitBox
maropu commented on a change in pull request #33212: URL: https://github.com/apache/spark/pull/33212#discussion_r671026357 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala ## @@ -418,6 +424,22 @@ class JacksonParser( }

[GitHub] [spark] maropu commented on a change in pull request #33212: [SPARK-35912][SQL] Fix nullability of `spark.read.json`

2021-07-11 Thread GitBox
maropu commented on a change in pull request #33212: URL: https://github.com/apache/spark/pull/33212#discussion_r667665862 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala ## @@ -2924,6 +2924,61 @@ abstract class JsonSuite

[GitHub] [spark] maropu commented on a change in pull request #33212: [SPARK-35912][SQL] Fix nullability of `spark.read.json`

2021-07-11 Thread GitBox
maropu commented on a change in pull request #33212: URL: https://github.com/apache/spark/pull/33212#discussion_r667665610 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JacksonParserSuite.scala ## @@ -54,4 +55,64 @@ class JacksonParserSuite exten

[GitHub] [spark] maropu commented on a change in pull request #33212: [SPARK-35912][SQL] Fix nullability of `spark.read.json`

2021-07-11 Thread GitBox
maropu commented on a change in pull request #33212: URL: https://github.com/apache/spark/pull/33212#discussion_r667665051 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/json/JacksonParserSuite.scala ## @@ -54,4 +55,64 @@ class JacksonParserSuite exten

[GitHub] [spark] maropu commented on a change in pull request #33212: [SPARK-35912][SQL] Fix nullability of `spark.read.json`

2021-07-11 Thread GitBox
maropu commented on a change in pull request #33212: URL: https://github.com/apache/spark/pull/33212#discussion_r667664747 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala ## @@ -418,6 +426,19 @@ class JacksonParser( }