[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-532027800 Thanks! Merged to master. Thanks for all the reviewers! @rednaxelafx if you have

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-531420773 retest this please

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-531420748 ping @rednaxelafx

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-530619053 ping @cloud-fan @viirya

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-530619063 retest this please

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-530144242 ``` (base) maropu@~:$system_profiler SPHardwareDataType Hardware: Hardware

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-529937621 oh... I forgot to re-benchmark that. (I put wrong benchmark numbers first, so I

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-529178128 retest this please

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-529156109 Ah, that's one of choices. I'll try to brush up the code based on that. Thanks!

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-529045841 Yea, I think so, too. If its possible for a split function to return two variables

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-529031402 also cc: @cloud-fan @rednaxelafx @mgaido91

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-529030889 > I also ran this benchmark to verify, but seems current master doesn't take so long

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-528881932 retest this please