[GitHub] [spark] maropu commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark

2019-09-12 Thread GitBox
maropu commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark URL: https://github.com/apache/spark/pull/25772#issuecomment-530803392 Thanks! Merged to master. This is an automated message from the

[GitHub] [spark] maropu commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark

2019-09-12 Thread GitBox
maropu commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark URL: https://github.com/apache/spark/pull/25772#issuecomment-530702729 hahaha, I was faster This is an automated message from the Apache

[GitHub] [spark] maropu commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark

2019-09-12 Thread GitBox
maropu commented on issue #25772: [SPARK-29065][SQL][TEST] Extend `EXTRACT` benchmark URL: https://github.com/apache/spark/pull/25772#issuecomment-530700815 Ur, I see. I didn't notice we've already accepted explicit casts from long to timestamp though, any reason to support this explicit