[GitHub] [spark] maropu commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation

2019-11-03 Thread GitBox
maropu commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation URL: https://github.com/apache/spark/pull/26011#issuecomment-549240339 Thanks, @WangGuangxin and @cloud-fan ! -

[GitHub] [spark] maropu commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation

2019-11-03 Thread GitBox
maropu commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation URL: https://github.com/apache/spark/pull/26011#issuecomment-549206336 @dilipbiswal @cloud-fan Looks good overall and could you check this? ---

[GitHub] [spark] maropu commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation

2019-10-23 Thread GitBox
maropu commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation URL: https://github.com/apache/spark/pull/26011#issuecomment-545305191 @WangGuangxin Are you there? Can you update the pr based on the reviews above?