maropu commented on issue #26420: [SPARK-27986][SQL] Support ANSI SQL filter
predicate for aggregate expression.
URL: https://github.com/apache/spark/pull/26420#issuecomment-557949783
@beliefer Why did you close this?
This
maropu commented on issue #26420: [SPARK-27986][SQL] Support ANSI SQL filter
predicate for aggregate expression.
URL: https://github.com/apache/spark/pull/26420#issuecomment-557793163
Can you check the BNF grammar for `` defined in the ANSI/SQL
standard?
maropu commented on issue #26420: [SPARK-27986][SQL] Support ANSI SQL filter
predicate for aggregate expression.
URL: https://github.com/apache/spark/pull/26420#issuecomment-553785466
This case?
```
//PgSQL
postgres=# select * from t;
k | v1 | v2
---++
1 | 1 |
maropu commented on issue #26420: [SPARK-27986][SQL] Support ANSI SQL filter
predicate for aggregate expression.
URL: https://github.com/apache/spark/pull/26420#issuecomment-552186656
I meant we might not need to modify the physical plans for aggregates (e.g.,
HashAggregateExec). Instead,
maropu commented on issue #26420: [SPARK-27986][SQL] Support ANSI SQL filter
predicate for aggregate expression.
URL: https://github.com/apache/spark/pull/26420#issuecomment-551848131
Ur, I see nice suggestion. I need more time to think about how to
implement.
maropu commented on issue #26420: [SPARK-27986][SQL] Support ANSI SQL filter
predicate for aggregate expression.
URL: https://github.com/apache/spark/pull/26420#issuecomment-551834128
I just thought a super simple case like this;
```
postgres=# select * from t;
k | v1 | v2
maropu commented on issue #26420: [SPARK-27986][SQL] Support ANSI SQL filter
predicate for aggregate expression.
URL: https://github.com/apache/spark/pull/26420#issuecomment-551633363
I just looked over the current implementation though, I have one question;
have you checked that we
