[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-12-24 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-751132617 Thanks for your review, Dongjoon ! Yea, you, too. Happy Merry Christmas! This is an automated message from the

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-12-21 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-749285252 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-12-20 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-748711230 Thanks for taking care of it, @HeartSaVioR. If there are no reviewer who is against this PR and one has no more comment, I will merge this for the v3.2.0 release in a few weeks.

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-31 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-667443218 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-21 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-662170929 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-16 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-659770051 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-10 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-656922493 kindly ping @cloud-fan This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-06 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-654057358 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-04 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-653752107 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-06-20 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-646963210 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-06-09 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-641077009 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-05-22 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-632675142 Thanks, @kiszk. Yea, since the aggregate class is frequently-used one, so I just think more reviewers would be better to check the changes. As you know, the two release voting

[GitHub] [spark] maropu commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-04-27 Thread GitBox
maropu commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-619775541 retest this please This is an automated message from the Apache Git Service. To respond to the message, please