[GitHub] [spark] maropu commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-29 Thread GitBox
maropu commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-664710547 Merged to master/branch-3.0. Thanks, @GuoPhilipse ! This is an automated message from the Apache Git Service. To

[GitHub] [spark] maropu commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-22 Thread GitBox
maropu commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-662769125 Note: If nobody has comments, this is just a doc improvement, so I will merge in a few days. This is an automate

[GitHub] [spark] maropu commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-22 Thread GitBox
maropu commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-662768621 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-21 Thread GitBox
maropu commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-661813979 @GuoPhilipse Btw, we still have more document improvement issues; 1. Improve the structure of auto-generated built-in function pages in SQL references, https://issues.apache.o

[GitHub] [spark] maropu commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-21 Thread GitBox
maropu commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-661688610 @GuoPhilipse Could you generate HTML docs and check if all things are okay for this udpate? In most PRs for doc updates, the screenshots of HTML docs are often attached in the

[GitHub] [spark] maropu commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-21 Thread GitBox
maropu commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-661685138 Thanks for the work, @GuoPhilipse ! Looks ok except for one comment. Could you check for the final sign-off? @srowen @dongjoon-hyun @huaxingao @dilipbiswal Note: since all the SQ

[GitHub] [spark] maropu commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-17 Thread GitBox
maropu commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-660126856 btw, could you update the PR description, too? e.g., remove `FROM` This is an automated message from the Apache G

[GitHub] [spark] maropu commented on pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-14 Thread GitBox
maropu commented on pull request #29056: URL: https://github.com/apache/spark/pull/29056#issuecomment-658487140 Great thanks for the work, @GuoPhilipse, but could you carefully check the formats in the other doc pages, again? ---