[GitHub] [spark] maropu commented on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-23 Thread GitBox
maropu commented on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-662907451 Forbitting it in in-memory catalog, too, looks ok to me. If we get a user's request about the behaivour, we can easily fix it. --

[GitHub] [spark] maropu commented on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-22 Thread GitBox
maropu commented on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-662767785 Looks okay to me, but (this is trivial though) we might need to choose either action?; - jira type: `improvement` -> `bug`, then backport this to `branch-3.0`/`branch-2.4`, o

[GitHub] [spark] maropu commented on pull request #29152: [SPARK-32356][SQL] Forbid create view with null type

2020-07-21 Thread GitBox
maropu commented on pull request #29152: URL: https://github.com/apache/spark/pull/29152#issuecomment-661902376 hm, at least, most databases can accpet it `create view v as select null`, but `null` is regared as another type, e.g., a text in postgresql; ``` postgres=# create view v as