[GitHub] [spark] maropu commented on pull request #29192: [SPARK-32393][SQL] Fix postgres bpchar array support

2020-07-22 Thread GitBox
maropu commented on pull request #29192: URL: https://github.com/apache/spark/pull/29192#issuecomment-662790228 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on pull request #29192: [SPARK-32393][SQL] Fix postgres bpchar array support

2020-07-22 Thread GitBox
maropu commented on pull request #29192: URL: https://github.com/apache/spark/pull/29192#issuecomment-662784282 btw, thanks for your contribution, @kujon ! This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] maropu commented on pull request #29192: [SPARK-32393][SQL] Fix postgres bpchar array support

2020-07-22 Thread GitBox
maropu commented on pull request #29192: URL: https://github.com/apache/spark/pull/29192#issuecomment-662779093 `bpchar` is internally used in postgresql (https://www.postgresql.org/docs/current/typeconv-query.html), but users can use it in DDL; ``` postgres=# create table t (v bpcha

[GitHub] [spark] maropu commented on pull request #29192: [SPARK-32393][SQL] Fix postgres bpchar array support

2020-07-22 Thread GitBox
maropu commented on pull request #29192: URL: https://github.com/apache/spark/pull/29192#issuecomment-662778415 Could you add tests in `PostgresIntegrationSuite` then check if the test can pass on your local env? (Note: our testing framework, Jenkins, does not run it). ---