[GitHub] [spark] mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-29 Thread GitBox
mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-516193440 @vanzin @squito latest patch addresses a bunch of comments. Please take a look. -

[GitHub] [spark] mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-29 Thread GitBox
mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-516099580 retest this please This is an automated message from the

[GitHub] [spark] mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-24 Thread GitBox
mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-514834823 Addressed the comments as of latest. Particularly consolidated some of the interfaces together. Please take a look. -

[GitHub] [spark] mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-23 Thread GitBox
mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-514416710 @squito @vanzin @gczsjdy any remaining comments to add? T

[GitHub] [spark] mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-19 Thread GitBox
mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-513344128 Ok I've addressed all the comments. This is an automated

[GitHub] [spark] mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-10 Thread GitBox
mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-510192044 Ok I've addressed all the comments thus far. Any further feedback is appreciated. ---

[GitHub] [spark] mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-06-28 Thread GitBox
mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-506831721 @jerryshao @squito @yifeih This is an automated message

[GitHub] [spark] mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-06-28 Thread GitBox
mccheah commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-506831440 ok to test This is an automated message from the Apache G