[GitHub] [spark] mccheah commented on pull request #28618: [SPARK-31801][API][SHUFFLE] Register map output metadata

2020-09-14 Thread GitBox
mccheah commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-692182889 > Btw, noticed that updateMapOutput was added as part of executor decommission support. We will need to hook that into ShuffleOutputTracker as well. @mridulm Can we also

[GitHub] [spark] mccheah commented on pull request #28618: [SPARK-31801][API][SHUFFLE] Register map output metadata

2020-09-09 Thread GitBox
mccheah commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-689907234 @tgravescs sorry for the delay - addressed all the comments above. This is an automated message from the Apache

[GitHub] [spark] mccheah commented on pull request #28618: [SPARK-31801][API][SHUFFLE] Register map output metadata

2020-08-13 Thread GitBox
mccheah commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-673599684 Ping here - what would be the best way to get this merged? This is an automated message from the Apache Git Serv

[GitHub] [spark] mccheah commented on pull request #28618: [SPARK-31801][API][SHUFFLE] Register map output metadata

2020-08-04 Thread GitBox
mccheah commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-668727372 Ok, I think the build passes according to Jenkins, though the tests run by Github actions appears to have been flaky. This is ready for review or for sign off. ---

[GitHub] [spark] mccheah commented on pull request #28618: [SPARK-31801][API][SHUFFLE] Register map output metadata

2020-07-30 Thread GitBox
mccheah commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-666753064 Took a pass through this to address @attilapiros's latest comments and also to merge with the upstream master branch. Is there any more feedback for this PR, or this feature as