[GitHub] [spark] mridulm commented on pull request #36467: [SPARK-39063][CORE] Fix potential risk of JVM crash and `RocksDBIterator` resource leak

2022-05-09 Thread GitBox
mridulm commented on PR #36467: URL: https://github.com/apache/spark/pull/36467#issuecomment-1121625153 I have not looked into this in great detail, but why not simply return a boolean from `notifyIteratorClosed` to indicate if the underlying db has been closed or not ? This can be used

[GitHub] [spark] mridulm commented on pull request #36467: [SPARK-39063][CORE] Fix potential risk of JVM crash and `RocksDBIterator` resource leak

2022-05-10 Thread GitBox
mridulm commented on PR #36467: URL: https://github.com/apache/spark/pull/36467#issuecomment-1122644890 > The issue to be solved is: Ensure all RocksDBIterators are clsoed before the RocksDB is closed, otherwise the JVM will crash when use a rocksdb with debug mode enabled. This is a

[GitHub] [spark] mridulm commented on pull request #36467: [SPARK-39063][CORE] Fix potential risk of JVM crash and `RocksDBIterator` resource leak

2022-05-10 Thread GitBox
mridulm commented on PR #36467: URL: https://github.com/apache/spark/pull/36467#issuecomment-1123118193 > If the definition of iteratorTracker is changed from ConcurrentLinkedQueue>> to ConcurrentLinkedQueue> , then you are right. It should not need change types. In the current co