[GitHub] [spark] mridulm commented on pull request #40687: [SPARK-43052][CORE] Handle stacktrace with null file name in event log

2023-04-26 Thread via GitHub
mridulm commented on PR #40687: URL: https://github.com/apache/spark/pull/40687#issuecomment-1524683595 Merging to master. Thanks for fixing this @warrenzhu25 Thanks for the review @HyukjinKwon, @srowen :-) -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [spark] mridulm commented on pull request #40687: [SPARK-43052][CORE] Handle stacktrace with null file name in event log

2023-04-20 Thread via GitHub
mridulm commented on PR #40687: URL: https://github.com/apache/spark/pull/40687#issuecomment-1517348391 +CC @dongjoon-hyun for review, since you took a look at this PR before -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] mridulm commented on pull request #40687: [SPARK-43052][CORE] Handle stacktrace with null file name in event log

2023-04-20 Thread via GitHub
mridulm commented on PR #40687: URL: https://github.com/apache/spark/pull/40687#issuecomment-1517319566 Looks like my comments were not addressed ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] mridulm commented on pull request #40687: [SPARK-43052][CORE] Handle stacktrace with null file name in event log

2023-04-06 Thread via GitHub
mridulm commented on PR #40687: URL: https://github.com/apache/spark/pull/40687#issuecomment-1499303226 Filename can be null, my query was about description :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] mridulm commented on pull request #40687: [SPARK-43052][CORE] Handle stacktrace with null file name in event log

2023-04-06 Thread via GitHub
mridulm commented on PR #40687: URL: https://github.com/apache/spark/pull/40687#issuecomment-1499296690 QQ: When does description actually become `null` ? (other than synthetic cases like tests) -- This is an automated message from the Apache Git Service. To respond to the message, please