[GitHub] [spark] navinvishy commented on a diff in pull request #38947: SPARK-41231: Adds an array_prepend function to catalyst

navinvishy commented on code in PR #38947: URL: https://github.com/apache/spark/pull/38947#discussion_r1041589578 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala: ## @@ -2645,78 +2257,103 @@ class DataFrameFunctionsSuite extends QueryTest with Shar

[GitHub] [spark] navinvishy commented on a diff in pull request #38947: SPARK-41231: Adds an array_prepend function to catalyst

navinvishy commented on code in PR #38947: URL: https://github.com/apache/spark/pull/38947#discussion_r1041589182 ## sql/core/src/main/scala/org/apache/spark/sql/functions.scala: ## @@ -4018,10 +4181,22 @@ object functions { * @group collection_funcs * @since 2.4.0 *

[GitHub] [spark] navinvishy commented on a diff in pull request #38947: SPARK-41231: Adds an array_prepend function to catalyst

navinvishy commented on code in PR #38947: URL: https://github.com/apache/spark/pull/38947#discussion_r1041588680 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala: ## @@ -1840,6 +1939,47 @@ class CollectionExpressionsSuite

[GitHub] [spark] navinvishy commented on a diff in pull request #38947: SPARK-41231: Adds an array_prepend function to catalyst

navinvishy commented on code in PR #38947: URL: https://github.com/apache/spark/pull/38947#discussion_r1041588232 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala: ## @@ -692,6 +696,7 @@ object FunctionRegistry { expression[Sequen

[GitHub] [spark] navinvishy commented on a diff in pull request #38947: SPARK-41231: Adds an array_prepend function to catalyst

navinvishy commented on code in PR #38947: URL: https://github.com/apache/spark/pull/38947#discussion_r1041587895 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala: ## @@ -1376,35 +1418,148 @@ case class ArrayContains(left: Expre