panbingkun commented on PR #40506:
URL: https://github.com/apache/spark/pull/40506#issuecomment-1670579488
> @panbingkun Could you rebase this PR on the recent master and resolve
conflicts, please.
@MaxGekk Done, Thanks.
--
This is an automated message from the Apache Git Service.
panbingkun commented on PR #40506:
URL: https://github.com/apache/spark/pull/40506#issuecomment-1633648972
Friendly ping @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
panbingkun commented on PR #40506:
URL: https://github.com/apache/spark/pull/40506#issuecomment-1630931255
Its principle is similar to the following diagram (Although the diagram says
Hive UDF Codgen)
https://github.com/apache/spark/assets/15246973/b748afb4-28a5-471c-a89b-a9b8dc597378";>
panbingkun commented on PR #40506:
URL: https://github.com/apache/spark/pull/40506#issuecomment-1630922534
> @panbingkun Please, resolve conflicts.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
panbingkun commented on PR #40506:
URL: https://github.com/apache/spark/pull/40506#issuecomment-1623726609
> I am not sure why this should improve performance but in general LGTM.
@HyukjinKwon WDYT?
In our production environment, it has indeed improved query performance for
some scen
panbingkun commented on PR #40506:
URL: https://github.com/apache/spark/pull/40506#issuecomment-1563673976
> @panbingkun Could you resolve conflicts, please.
This is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
panbingkun commented on PR #40506:
URL: https://github.com/apache/spark/pull/40506#issuecomment-1563033876
> @panbingkun Could you resolve conflicts, please.
Let me update the results of `JsonBenchmark` again. Waiting for it.
Thank you for your review! @MaxGekk
--
This is an aut
panbingkun commented on PR #40506:
URL: https://github.com/apache/spark/pull/40506#issuecomment-1480968971
> @panbingkun I think we should also update
`JsonBenchmark-jdk11-results.txt`, `JsonBenchmark-jdk17-results.txt` and
`JsonBenchmark-results.txt` in this pr due to `JsonBenchmark` updat
panbingkun commented on PR #40506:
URL: https://github.com/apache/spark/pull/40506#issuecomment-1479624519
> hmm... I think we should refactor `JsonBenchmark` to make get_json_object
run w/ and w/o code gen in one
Ok, Let me do it.
--
This is an automated message from the Apache Gi
panbingkun commented on PR #40506:
URL: https://github.com/apache/spark/pull/40506#issuecomment-1479567656
cc @cloud-fan @wangyum @LuciferYang
I run benchmark -
org.apache.spark.sql.execution.datasources.json.JsonBenchmark, result as follow:
- CodeGen for get_json_object
https:
10 matches
Mail list logo
