[GitHub] [spark] peter-toth commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-13 Thread GitBox
peter-toth commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite URL: https://github.com/apache/spark/pull/26028#issuecomment-541397374 Thank you @dongjoon-hyun and @wangyum for the review.

[GitHub] [spark] peter-toth commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-10 Thread GitBox
peter-toth commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite URL: https://github.com/apache/spark/pull/26028#issuecomment-540414457 @dongjoon-hyun @wangyum do you this PR is ok now?

[GitHub] [spark] peter-toth commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-06 Thread GitBox
peter-toth commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite URL: https://github.com/apache/spark/pull/26028#issuecomment-538780313 > Could you give us more concrete example when this PR becomes more meaningful? For now,

[GitHub] [spark] peter-toth commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-06 Thread GitBox
peter-toth commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite URL: https://github.com/apache/spark/pull/26028#issuecomment-538770653 > I'll review this again after the removal of the first one. Thanks. Ok, thanks. I