[GitHub] [spark] peter-toth commented on pull request #32396: [SPARK-34581][SQL] Don't optimize out grouping expressions from aggregate expressions without aggregate function

peter-toth commented on pull request #32396: URL: https://github.com/apache/spark/pull/32396#issuecomment-831759715 Thanks @maropu for the extended test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [spark] peter-toth commented on pull request #32396: [SPARK-34581][SQL] Don't optimize out grouping expressions from aggregate expressions without aggregate function

peter-toth commented on pull request #32396: URL: https://github.com/apache/spark/pull/32396#issuecomment-830774705 Thanks all for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] peter-toth commented on pull request #32396: [SPARK-34581][SQL] Don't optimize out grouping expressions from aggregate expressions without aggregate function

peter-toth commented on pull request #32396: URL: https://github.com/apache/spark/pull/32396#issuecomment-830670216 TPCDS [benchmark](https://github.com/peter-toth/spark/commit/fb9de2e563d712227bd7178dca4ed5a66f06d400) on scaleFactor=5 data looks good, no significant change: [TPCDSQueryBe

[GitHub] [spark] peter-toth commented on pull request #32396: [SPARK-34581][SQL] Don't optimize out grouping expressions from aggregate expressions without aggregate function

peter-toth commented on pull request #32396: URL: https://github.com/apache/spark/pull/32396#issuecomment-830576161 > LGTM if TPCDS result shows no perf regression Running it, will post the results today. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [spark] peter-toth commented on pull request #32396: [SPARK-34581][SQL] Don't optimize out grouping expressions from aggregate expressions without aggregate function

peter-toth commented on pull request #32396: URL: https://github.com/apache/spark/pull/32396#issuecomment-829352341 > The code change looks good. Can we run a TPCDS benchmark to make sure there is no perf regression? I will run it and post the results soon. -- This is an automated

[GitHub] [spark] peter-toth commented on pull request #32396: [SPARK-34581][SQL] Don't optimize out grouping expressions from aggregate expressions without aggregate function

peter-toth commented on pull request #32396: URL: https://github.com/apache/spark/pull/32396#issuecomment-829205097 @sigmod, @cloud-fan this is the alternative PR to https://github.com/apache/spark/pull/31913 -- This is an automated message from the Apache Git Service. To respond to the