[GitHub] [spark] prakharjain09 commented on pull request #30426: [SPARK-33486][SQL] Collapse Partial and Final physical aggregation nodes together whenever possible

2020-11-26 Thread GitBox
prakharjain09 commented on pull request #30426: URL: https://github.com/apache/spark/pull/30426#issuecomment-734668231 > So, could you give us a concrete example of how much it will improve performance? @maropu We have seen customer queries where Aggregation happens on close to prim

[GitHub] [spark] prakharjain09 commented on pull request #30426: [SPARK-33486][SQL] Collapse Partial and Final physical aggregation nodes together whenever possible

2020-11-22 Thread GitBox
prakharjain09 commented on pull request #30426: URL: https://github.com/apache/spark/pull/30426#issuecomment-731980696 @maropu @cloud-fan Gentle reminder - Please review the changes and provide your feedback. This is an auto

[GitHub] [spark] prakharjain09 commented on pull request #30426: [SPARK-33486][SQL] Collapse Partial and Final physical aggregation nodes together whenever possible

2020-11-19 Thread GitBox
prakharjain09 commented on pull request #30426: URL: https://github.com/apache/spark/pull/30426#issuecomment-730533709 @maropu Thanks for pointing out to old PR and jirs - Yes SPARK-12978 seems related to SPARK-33486. > Btw, have you checked if this optimization could make some queri

[GitHub] [spark] prakharjain09 commented on pull request #30426: [SPARK-33486][SQL] Collapse Partial and Final physical aggregation nodes together whenever possible

2020-11-19 Thread GitBox
prakharjain09 commented on pull request #30426: URL: https://github.com/apache/spark/pull/30426#issuecomment-730345926 cc - @maropu @cloud-fan @dongjoon-hyun This is an automated message from the Apache Git Service. To respo