[GitHub] [spark] rangadi commented on pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

2023-05-27 Thread via GitHub
rangadi commented on PR #41192: URL: https://github.com/apache/spark/pull/41192#issuecomment-1565463249 @LuciferYang all the test pass could you merge? I have multiple PRs waiting for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] rangadi commented on pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

2023-05-25 Thread via GitHub
rangadi commented on PR #41192: URL: https://github.com/apache/spark/pull/41192#issuecomment-1563840708 @LuciferYang please let me know if you need any more changes. If none, I can ask someone else to take a look and merge as well. -- This is an automated message from the Apache Git Servi

[GitHub] [spark] rangadi commented on pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

2023-05-25 Thread via GitHub
rangadi commented on PR #41192: URL: https://github.com/apache/spark/pull/41192#issuecomment-1563840198 @LuciferYang do you need any more changes for this? I fixed a test that fails only github CI. I would like to get this merged asap. -- This is an automated message from the Apache G

[GitHub] [spark] rangadi commented on pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

2023-05-18 Thread via GitHub
rangadi commented on PR #41192: URL: https://github.com/apache/spark/pull/41192#issuecomment-1553438582 @SandishKumarHN Please approve if this looks good. Would like to merge this soon if there are no outstanding issues. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] rangadi commented on pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

2023-05-17 Thread via GitHub
rangadi commented on PR #41192: URL: https://github.com/apache/spark/pull/41192#issuecomment-1552404914 @gengliangwang PTAL when you get chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] rangadi commented on pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

2023-05-17 Thread via GitHub
rangadi commented on PR #41192: URL: https://github.com/apache/spark/pull/41192#issuecomment-1552305443 @advancedxy broadcast is an interesting idea. Lets continue the discussion in a code comment here: https://github.com/apache/spark/pull/41192#discussion_r1197264386 -- This is an autom

[GitHub] [spark] rangadi commented on pull request #41192: [SPARK-43530][PROTOBUF] Read descriptor file only once

2023-05-16 Thread via GitHub
rangadi commented on PR #41192: URL: https://github.com/apache/spark/pull/41192#issuecomment-1550478215 cc: @SandishKumarHN, @justaparth, @gengliangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to