[GitHub] [spark] rednaxelafx edited a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-28 Thread GitBox
rednaxelafx edited a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525603727 Thanks for working on this PR, @maropu ! The new generated code looks a lot better! I'll go into more detai

[GitHub] [spark] rednaxelafx edited a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
rednaxelafx edited a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525603727 Thanks for working on this PR, @maropu ! The new generated code looks a lot better! I'll go into more detai