[GitHub] [spark] rshkv commented on a diff in pull request #40794: [SPARK-43142] Fix DSL expressions on attributes with special characters

2023-04-21 Thread via GitHub
rshkv commented on code in PR #40794: URL: https://github.com/apache/spark/pull/40794#discussion_r1173669012 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala: ## @@ -271,7 +271,7 @@ package object dsl { override def expr: Expression = Literal

[GitHub] [spark] rshkv commented on a diff in pull request #40794: [SPARK-43142] Fix DSL expressions on attributes with special characters

2023-04-21 Thread via GitHub
rshkv commented on code in PR #40794: URL: https://github.com/apache/spark/pull/40794#discussion_r1173675183 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala: ## @@ -271,14 +271,17 @@ package object dsl { override def expr: Expression = Liter

[GitHub] [spark] rshkv commented on a diff in pull request #40794: [SPARK-43142] Fix DSL expressions on attributes with special characters

2023-04-21 Thread via GitHub
rshkv commented on code in PR #40794: URL: https://github.com/apache/spark/pull/40794#discussion_r1173669012 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala: ## @@ -271,7 +271,7 @@ package object dsl { override def expr: Expression = Literal

[GitHub] [spark] rshkv commented on a diff in pull request #40794: [SPARK-43142] Fix DSL expressions on attributes with special characters

2023-04-21 Thread via GitHub
rshkv commented on code in PR #40794: URL: https://github.com/apache/spark/pull/40794#discussion_r1173564024 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala: ## @@ -271,7 +271,7 @@ package object dsl { override def expr: Expression = Literal

[GitHub] [spark] rshkv commented on a diff in pull request #40794: [SPARK-43142] Fix DSL expressions on attributes with special characters

2023-04-21 Thread via GitHub
rshkv commented on code in PR #40794: URL: https://github.com/apache/spark/pull/40794#discussion_r1173564024 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala: ## @@ -271,7 +271,7 @@ package object dsl { override def expr: Expression = Literal

[GitHub] [spark] rshkv commented on a diff in pull request #40794: [SPARK-43142] Fix DSL expressions on attributes with special characters

2023-04-20 Thread via GitHub
rshkv commented on code in PR #40794: URL: https://github.com/apache/spark/pull/40794#discussion_r1173035633 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala: ## @@ -271,7 +271,7 @@ package object dsl { override def expr: Expression = Literal