[GitHub] [spark] sadikovi edited a comment on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-25 Thread GitBox
sadikovi edited a comment on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-978913178 The benchmark results are fairly the same, there is some variability. I think we are good here, no separate option is required. Without the PR changes

[GitHub] [spark] sadikovi edited a comment on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-24 Thread GitBox
sadikovi edited a comment on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-978881155 @gengliangwang @cloud-fan I updated the code, can you review again? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] sadikovi edited a comment on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source

2021-11-18 Thread GitBox
sadikovi edited a comment on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-973796214 IMHO, we should revert to the original proposal with `isTimeZoneSet` method: it preserves the original API at the expense of having an additional method to check