[GitHub] [spark] sandip-db commented on a diff in pull request #42938: [SPARK-44788][CONNECT][PYTHON][SQL] Add from_xml and schema_of_xml to pyspark, spark connect and sql function

2023-09-17 Thread via GitHub
sandip-db commented on code in PR #42938: URL: https://github.com/apache/spark/pull/42938#discussion_r1328227219 ## python/pyspark/sql/tests/connect/test_connect_function.py: ## @@ -1821,6 +1821,111 @@ def test_json_functions(self):

[GitHub] [spark] sandip-db commented on a diff in pull request #42938: [SPARK-44788][CONNECT][PYTHON][SQL] Add from_xml and schema_of_xml to pyspark, spark connect and sql function

2023-09-17 Thread via GitHub
sandip-db commented on code in PR #42938: URL: https://github.com/apache/spark/pull/42938#discussion_r1328196005 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/FunctionTestSuite.scala: ## @@ -229,6 +229,18 @@ class FunctionTestSuite extends ConnectFunSuite

[GitHub] [spark] sandip-db commented on a diff in pull request #42938: [SPARK-44788][CONNECT][PYTHON][SQL] Add from_xml and schema_of_xml to pyspark, spark connect and sql function

2023-09-16 Thread via GitHub
sandip-db commented on code in PR #42938: URL: https://github.com/apache/spark/pull/42938#discussion_r1328021810 ## python/pyspark/sql/functions.py: ## @@ -13041,6 +13041,120 @@ def json_object_keys(col: "ColumnOrName") -> Column: return

[GitHub] [spark] sandip-db commented on a diff in pull request #42938: [SPARK-44788][CONNECT][PYTHON][SQL] Add from_xml and schema_of_xml to pyspark, spark connect and sql function

2023-09-15 Thread via GitHub
sandip-db commented on code in PR #42938: URL: https://github.com/apache/spark/pull/42938#discussion_r1327417666 ## connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/FunctionTestSuite.scala: ## @@ -229,6 +229,18 @@ class FunctionTestSuite extends ConnectFunSuite

[GitHub] [spark] sandip-db commented on a diff in pull request #42938: [SPARK-44788][CONNECT][PYTHON][SQL] Add from_xml and schema_of_xml to pyspark, spark connect and sql function

2023-09-15 Thread via GitHub
sandip-db commented on code in PR #42938: URL: https://github.com/apache/spark/pull/42938#discussion_r1327401538 ## python/pyspark/sql/tests/connect/test_connect_function.py: ## @@ -1821,6 +1821,106 @@ def test_json_functions(self):