[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r717193191 ## File path: core/src/test/scala/org/apache/spark/status/AppStatusStoreSuite.scala ## @@ -136,6 +139,51 @@ class AppStatusStoreSuite extends

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r717193191 ## File path: core/src/test/scala/org/apache/spark/status/AppStatusStoreSuite.scala ## @@ -136,6 +139,51 @@ class AppStatusStoreSuite extends

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r704911903 ## File path: core/src/test/resources/HistoryServerExpectations/stage_with_speculation_summary_expectation.json ## @@ -0,0 +1,510 @@ +{ + "status" :

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r697670769 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -1208,6 +1232,33 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r693123565 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -1208,6 +1232,33 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r693123565 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -1208,6 +1232,33 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r688209434 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -1208,6 +1232,33 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r688209434 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -1208,6 +1232,33 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r688209434 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -1208,6 +1232,33 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r682624830 ## File path: core/src/test/resources/HistoryServerExpectations/stage_with_speculation_summary_expectation.json ## @@ -0,0 +1,748 @@ +{ Review comment:

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r682632459 ## File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ## @@ -89,6 +89,14 @@ class ExecutorStageSummary private[spark]( val

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r682624830 ## File path: core/src/test/resources/HistoryServerExpectations/stage_with_speculation_summary_expectation.json ## @@ -0,0 +1,748 @@ +{ Review comment:

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r680634284 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -1208,6 +1232,33 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r680634284 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -1208,6 +1232,33 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r680634284 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -1208,6 +1232,33 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r680625508 ## File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ## @@ -89,6 +89,14 @@ class ExecutorStageSummary private[spark]( val

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r680624326 ## File path: core/src/test/resources/HistoryServerExpectations/stage_with_speculation_summary_expectation.json ## @@ -0,0 +1,748 @@ +{ Review comment:

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r680623875 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -1208,6 +1232,33 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r676237515 ## File path: core/src/test/resources/HistoryServerExpectations/stage_with_speculation_summary_expectation.json ## @@ -0,0 +1,748 @@ +{ Review comment:

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r675309447 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -746,6 +752,24 @@ private[spark] class AppStatusListener(

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r675304991 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala ## @@ -524,6 +529,11 @@ private[spark] class AppStatusStore( }

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r675304991 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala ## @@ -524,6 +529,11 @@ private[spark] class AppStatusStore( }

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r675304991 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala ## @@ -524,6 +529,11 @@ private[spark] class AppStatusStore( }

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r674267708 ## File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala ## @@ -399,6 +399,21 @@ private[spark] class ExecutorStageSummaryWrapper( }

[GitHub] [spark] sarutak commented on a change in pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on a change in pull request #33253: URL: https://github.com/apache/spark/pull/33253#discussion_r669284266 ## File path: core/src/test/resources/HistoryServerExpectations/running_app_list_json_expectation.json ## @@ -1 +1 @@ -[ ] +[ ] Review comment: