[GitHub] [spark] sarutak commented on a change in pull request #33988: [SPARK-36683][SQL] Add new built-in SQL functions: SEC and CSC

2021-09-16 Thread GitBox
sarutak commented on a change in pull request #33988: URL: https://github.com/apache/spark/pull/33988#discussion_r710144894 ## File path: python/pyspark/sql/tests/test_functions.py ## @@ -157,6 +159,32 @@ def test_inverse_trig_functions(self): for c in cols:

[GitHub] [spark] sarutak commented on a change in pull request #33988: [SPARK-36683][SQL] Add new built-in SQL functions: SEC and CSC

2021-09-16 Thread GitBox
sarutak commented on a change in pull request #33988: URL: https://github.com/apache/spark/pull/33988#discussion_r710038686 ## File path: python/pyspark/sql/tests/test_functions.py ## @@ -157,6 +159,32 @@ def test_inverse_trig_functions(self): for c in cols:

[GitHub] [spark] sarutak commented on a change in pull request #33988: [SPARK-36683][SQL] Add new built-in SQL functions: SEC and CSC

2021-09-16 Thread GitBox
sarutak commented on a change in pull request #33988: URL: https://github.com/apache/spark/pull/33988#discussion_r710144894 ## File path: python/pyspark/sql/tests/test_functions.py ## @@ -157,6 +159,32 @@ def test_inverse_trig_functions(self): for c in cols:

[GitHub] [spark] sarutak commented on a change in pull request #33988: [SPARK-36683][SQL] Add new built-in SQL functions: SEC and CSC

2021-09-15 Thread GitBox
sarutak commented on a change in pull request #33988: URL: https://github.com/apache/spark/pull/33988#discussion_r709691558 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -361,6 +361,7 @@ object FunctionRegistry {

[GitHub] [spark] sarutak commented on a change in pull request #33988: [SPARK-36683][SQL] Add new built-in SQL functions: SEC and CSC

2021-09-15 Thread GitBox
sarutak commented on a change in pull request #33988: URL: https://github.com/apache/spark/pull/33988#discussion_r709691558 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -361,6 +361,7 @@ object FunctionRegistry {

[GitHub] [spark] sarutak commented on a change in pull request #33988: [SPARK-36683][SQL] Add new built-in SQL functions: SEC and CSC

2021-09-15 Thread GitBox
sarutak commented on a change in pull request #33988: URL: https://github.com/apache/spark/pull/33988#discussion_r709691558 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -361,6 +361,7 @@ object FunctionRegistry {

[GitHub] [spark] sarutak commented on a change in pull request #33988: [SPARK-36683][SQL] Add new built-in SQL functions: SEC and CSC

2021-09-13 Thread GitBox
sarutak commented on a change in pull request #33988: URL: https://github.com/apache/spark/pull/33988#discussion_r707925829 ## File path: sql/core/src/test/resources/sql-tests/results/operators.sql.out ## @@ -259,11 +259,83 @@ struct -- !query +select sec(1) +-- !query sch