[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-962913353 @venkata91 Sorry, but I'll revert this change. I've noticed that a stage page will stuck if we we use HistoryServer and the corresponding stage contains no speculative task.

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-932014324 @venkata91 BTW, could you update the doc for WebUI to explain this feature, or just file a JIRA? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-932006516 Mergint to `master`. Thank you @venkata91 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-932005869 @venkata91 Let me remove `cc @AngersZh @ron8hu` from the desription. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-919063719 Could you add updated screenshots on the **description** ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-885405263 > Ah I see, currently we are populating killedTasksSummary in SpeculationStageSummary only if the killed reason is another attempt succeeded. For other reasons, we are not

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-885389696 > killedTaskSummary when original attempt succeeded - https://user-images.githubusercontent.com/8871522/126575315-5e766870-eab4-4afc-a02f-ede63148692b.png killedTaskSummary

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-884464753 @venkata91 I checked out this change and accessed `/speculationSummary` but `killedTasksSummary` seems empty. Could you investigate the cause?

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-882532843 @venkata91 > it seems like something is wrong with the Github actions on my account therefore the tests are not able to run. I filed a support request with Github but they

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-882532843 @venkata91 > it seems like something is wrong with the Github actions on my account therefore the tests are not able to run. I filed a support request with Github but they

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-882532843 @venkata91 > it seems like something is wrong with the Github actions on my account therefore the tests are not able to run. I filed a support request with Github but they

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-881910368 Some tests seem to fail. Could you fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-879563645 @venkata91 Could you fix the style issue first? ``` [error]

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-877402668 @venkata91 Sorry if I'm confusing you. I told you two things (your change seems to fail to build and please enable GA on your account to run test). The failure and that GA is

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-876950853 @venkata91 I checked out your change and run it on GA on my account but it fails to build. ``` [error]

[GitHub] [spark] sarutak commented on pull request #33253: [SPARK-36038][CORE] Speculation metrics summary at stage level

sarutak commented on pull request #33253: URL: https://github.com/apache/spark/pull/33253#issuecomment-876901452 @venkata91 > @sarutak It seems like Github actions is disabled for my fork. I have requested them to enable it. Just curious, why do I need to enable it for my fork (repo)?