[GitHub] [spark] sarutak commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon

2021-11-24 Thread GitBox
sarutak commented on pull request #34676: URL: https://github.com/apache/spark/pull/34676#issuecomment-978899026 The change itself looks fine but we need to discuss this change is really necessary as @HyukjinKwon concerns. @dongjoon-hyun Do you have any opinions? I guess you sometimes ru

[GitHub] [spark] sarutak commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon

2021-11-23 Thread GitBox
sarutak commented on pull request #34676: URL: https://github.com/apache/spark/pull/34676#issuecomment-977529479 @LuciferYang Thank you @LuciferYang . It's better to note the command lines in `How was this patch tested?` in the description. -- This is an automated message from the Apa

[GitHub] [spark] sarutak commented on pull request #34676: [SPARK-37434][BUILD] Add a new profile to auto disable unsupported UTs on MacOs using Apple Silicon

2021-11-22 Thread GitBox
sarutak commented on pull request #34676: URL: https://github.com/apache/spark/pull/34676#issuecomment-975586524 @LuciferYang BTW, how about SBT? I think this change doesn't care SBT. Also, it's better to note how you tested more concretely (e.g. show the command lines) to allow revi