[GitHub] [spark] sathyaprakashg commented on pull request #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-30 Thread GitBox
sathyaprakashg commented on pull request #28222: URL: https://github.com/apache/spark/pull/28222#issuecomment-622256424 @cloud-fan @yaooqinn for great discussion on this. @yaooqinn has fixed getDays in the below PR and for getMonths we can agree on keeping the existing behavior as

[GitHub] [spark] sathyaprakashg commented on pull request #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-28 Thread GitBox
sathyaprakashg commented on pull request #28222: URL: https://github.com/apache/spark/pull/28222#issuecomment-620441968 > @sathyaprakashg Please, take a look at the PRs > #26337 > #27262 Thanks @MaxGekk for prompt reply. CalendarInterval change is not required to fix the

[GitHub] [spark] sathyaprakashg commented on pull request #28222: SPARK-31447 Fix issue in ExtractIntervalPart expression

2020-04-28 Thread GitBox
sathyaprakashg commented on pull request #28222: URL: https://github.com/apache/spark/pull/28222#issuecomment-620428630 @cloud-fan @MaxGekk @yaooqinn I am looking for help to review this PR created 2 weeks ago. Since you guys were involved in PR related to simillar change