[GitHub] [spark] shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-20 Thread GitBox
shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-544235157 Thanks @srowen @zhengruifeng This

[GitHub] [spark] shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-17 Thread GitBox
shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-543415126 retest this please This is an auto

[GitHub] [spark] shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-17 Thread GitBox
shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-543382825 Updated the PR. Locally verified.

[GitHub] [spark] shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-17 Thread GitBox
shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-543099248 Thanks @srowen . I will update it today. Actually, there seems an issue. I think `AvgMetrics` need

[GitHub] [spark] shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-08 Thread GitBox
shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-539857077 Thanks @zhengruifeng I will add metrics for `TrainValidationSplitModel` too. -

[GitHub] [spark] shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-08 Thread GitBox
shahidki31 commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-539445177 cc @zhengruifeng Kindly review