[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-840082578 Thanks @dongjoon-hyun and all for the reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839944639 Retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839944317 > changes look fine, assume it was manually tested Yes, I verified manually

[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839522797 Thanks. Let me retrgger that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839517711 Hi @HyukjinKwon All the tests are passing. Seems Linters, Licence job is failing. But that is unrelated to the PR. Is it a known failure? ![Screenshot 2021-05-12 at 12 30

[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-11 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839377762 > @shahidki31 can you retrigger the test please? https://github.com/shahidki31/spark/actions/runs/832876763 Sure @HyukjinKwon Let me check -- This is an automated

[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-11 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839377516 > https://github.com/shahidki31/spark/actions/runs/832876763 Sure @HyukjinKwon . Let me check -- This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-11 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839274801 @dongjoon-hyun I have updated the branch with master. Kindly review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] shahidki31 commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-11 Thread GitBox
shahidki31 commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839025192 Sure @dongjoon-hyun . Let me go through the doc. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and