[GitHub] [spark] shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2020-01-12 Thread GitBox
shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-573507459 Thanks a lot! Regards, Shiv On Sun, Jan 12, 2020 at 8:48 PM Dongjoon

[GitHub] [spark] shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2020-01-12 Thread GitBox
shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-573505866 Thanks. I am sorry about my oversight on the date. Regards, Shiv

[GitHub] [spark] shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2020-01-12 Thread GitBox
shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-573502250 I will be taking this up this week. ETA end of coming week. Regards, Shiv

[GitHub] [spark] shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2020-01-10 Thread GitBox
shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-573259533 > Gentle ping, @shivsood . Can u point me to any guidelines how to add a flag? any

[GitHub] [spark] shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-11-28 Thread GitBox
shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-559637012 Thanks for pointing this out. I wonder how i missed this point on backward

[GitHub] [spark] shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-07-25 Thread GitBox
shivsood commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-515102063 > +1, LGTM. Thank you, @shivsood . > > Merged to branch-2.4. (The integration