[GitHub] [spark] srielau commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-26 Thread via GitHub
srielau commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1337482091 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -5310,6 +5321,9 @@ class SQLConf extends Serializable with Logging with SqlApiConf {

[GitHub] [spark] srielau commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-25 Thread via GitHub
srielau commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1336596704 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala: ## @@ -61,64 +62,83 @@ case class PrintToStderr(child: Expression) extends UnaryEx

[GitHub] [spark] srielau commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-25 Thread via GitHub
srielau commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1336596068 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -6310,5 +6330,11 @@ "message" : [ "Failed to get block , which is not a shuffle block"

[GitHub] [spark] srielau commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-22 Thread via GitHub
srielau commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1334513626 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -4432,6 +4432,17 @@ object SQLConf { .booleanConf .createWithDefault(fal

[GitHub] [spark] srielau commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-22 Thread via GitHub
srielau commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1334513626 ## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ## @@ -4432,6 +4432,17 @@ object SQLConf { .booleanConf .createWithDefault(fal

[GitHub] [spark] srielau commented on a diff in pull request #42985: [SPARK-44838][SQL][WIP] raise_error improvement

2023-09-22 Thread via GitHub
srielau commented on code in PR #42985: URL: https://github.com/apache/spark/pull/42985#discussion_r1334511376 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala: ## @@ -61,68 +62,97 @@ case class PrintToStderr(child: Expression) extends UnaryEx