[GitHub] [spark] srowen commented on a diff in pull request #36457: [SPARK-39107][SQL] Account for empty string input in regex replace

2022-05-07 Thread GitBox
srowen commented on code in PR #36457: URL: https://github.com/apache/spark/pull/36457#discussion_r867352167 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -642,7 +642,7 @@ case class RegExpReplace(subject: Expression, reg

[GitHub] [spark] srowen commented on a diff in pull request #36457: [SPARK-39107][SQL] Account for empty string input in regex replace

2022-05-06 Thread GitBox
srowen commented on code in PR #36457: URL: https://github.com/apache/spark/pull/36457#discussion_r866781006 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -642,7 +642,7 @@ case class RegExpReplace(subject: Expression, reg

[GitHub] [spark] srowen commented on a diff in pull request #36457: [SPARK-39107][SQL] Account for empty string input in regex replace

2022-05-06 Thread GitBox
srowen commented on code in PR #36457: URL: https://github.com/apache/spark/pull/36457#discussion_r866766828 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -642,7 +642,7 @@ case class RegExpReplace(subject: Expression, reg

[GitHub] [spark] srowen commented on a diff in pull request #36457: [SPARK-39107][SQL] Account for empty string input in regex replace

2022-05-05 Thread GitBox
srowen commented on code in PR #36457: URL: https://github.com/apache/spark/pull/36457#discussion_r866464610 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala: ## @@ -642,7 +642,7 @@ case class RegExpReplace(subject: Expression, reg