[GitHub] [spark] srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence

2019-08-19 Thread GitBox
srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence URL: https://github.com/apache/spark/pull/25279#issuecomment-522761321 That could well be reasonable. I didn't do so simply because I wasn't aware of cases where the Oracle JDK

[GitHub] [spark] srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence

2019-08-08 Thread GitBox
srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence URL: https://github.com/apache/spark/pull/25279#issuecomment-519726687 Yeah this is great info. I understand that java.lang.Math is allowed to return slightly different results

[GitHub] [spark] srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence

2019-08-07 Thread GitBox
srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence URL: https://github.com/apache/spark/pull/25279#issuecomment-519195159 @gatorsmile here's a quick benchmark for `log()`: Previous: ``` Running benchmark: log Ru

[GitHub] [spark] srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence

2019-08-06 Thread GitBox
srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence URL: https://github.com/apache/spark/pull/25279#issuecomment-518917299 I did not benchmark this as I think it's a correctness issue that would be worth a perf hit. I also expect

[GitHub] [spark] srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence

2019-08-02 Thread GitBox
srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence URL: https://github.com/apache/spark/pull/25279#issuecomment-517753485 Merged to master This is an automated mes