[GitHub] [spark] srowen commented on pull request #28512: [SPARK-31688][WEBUI] Refactor Pagination framework

2020-05-21 Thread GitBox
srowen commented on pull request #28512: URL: https://github.com/apache/spark/pull/28512#issuecomment-632255678 Merged to master This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] srowen commented on pull request #28512: [SPARK-31688][WEBUI] Refactor Pagination framework

2020-05-18 Thread GitBox
srowen commented on pull request #28512: URL: https://github.com/apache/spark/pull/28512#issuecomment-630306454 I don't know enough to have a strong opinion, but it looks plausible and I think you know this code well. If it doesn't introduce any behavior change, just a cleanup, I think

[GitHub] [spark] srowen commented on pull request #28512: [SPARK-31688][WEBUI] Refactor Pagination framework

2020-05-16 Thread GitBox
srowen commented on pull request #28512: URL: https://github.com/apache/spark/pull/28512#issuecomment-629697554 Jenkins test this please This is an automated message from the Apache Git Service. To respond to the message,