[GitHub] [spark] srowen commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

2020-06-19 Thread GitBox
srowen commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-646703995 Jenkins test this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] srowen commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

2020-06-18 Thread GitBox
srowen commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-646427158 Hm, I'm a little uneasy about it, as that shade config was put in a long time ago to work around Guava issues. It may or may not be necessary, but, what if you leave it in?

[GitHub] [spark] srowen commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

2020-06-18 Thread GitBox
srowen commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-646316112 Oh I see. Do you have to remove the shade plugin config though? This is an automated message from the Apache Git

[GitHub] [spark] srowen commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

2020-06-18 Thread GitBox
srowen commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-646074812 What do you mean it's incorrect? This is an automated message from the Apache Git Service. To respond to the