srowen commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670797950
No -1 here. I don't object to the current change.
This is an automated message from the Apache Git Service.
To
srowen commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670794000
No, I don't feel that way. If others would like to merge, go ahead. I would
merge the narrower change myself, but do not object to the broader one.
srowen commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670786844
I did. If most of the changes are exceptions, that makes me wonder how much
this rule will just trigger false positives. I am not sure how worth it is to
enforce this if mostly
srowen commented on pull request #29121:
URL: https://github.com/apache/spark/pull/29121#issuecomment-670711092
My last comment was, why do we need to add the rule and then a ton of
exclusions? just remove the unused imports. That's a much narrower change
