[GitHub] [spark] srowen commented on pull request #31372: [SPARK-34272][SQL] Pretty SQL should check NonSQLExpression

2021-02-05 Thread GitBox
srowen commented on pull request #31372: URL: https://github.com/apache/spark/pull/31372#issuecomment-773362443 Fair enough, but it exists and already purports to provide a `.sql` method. You're already proposing a different/better `.sql` representation. Why wouldn't it be the natural home

[GitHub] [spark] srowen commented on pull request #31372: [SPARK-34272][SQL] Pretty SQL should check NonSQLExpression

2021-02-04 Thread GitBox
srowen commented on pull request #31372: URL: https://github.com/apache/spark/pull/31372#issuecomment-773362443 Fair enough, but it exists and already purports to provide a `.sql` method. You're already proposing a different/better `.sql` representation. Why wouldn't it be the natural home

[GitHub] [spark] srowen commented on pull request #31372: [SPARK-34272][SQL] Pretty SQL should check NonSQLExpression

2021-02-01 Thread GitBox
srowen commented on pull request #31372: URL: https://github.com/apache/spark/pull/31372#issuecomment-770899336 I mean, wouldn't it be simpler to give NonSQLExpression a .sql method for any future context in which it's used? if (despite the name) it always has a SQL representation? -