[GitHub] [spark] srowen commented on pull request #37058: [SPARK-39661][SQL] Avoid creating unnecessary SLF4J Logger

2022-07-08 Thread GitBox
srowen commented on PR #37058: URL: https://github.com/apache/spark/pull/37058#issuecomment-1178981149 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] srowen commented on pull request #37058: [SPARK-39661][SQL] Avoid creating unnecessary SLF4J Logger

2022-07-07 Thread GitBox
srowen commented on PR #37058: URL: https://github.com/apache/spark/pull/37058#issuecomment-1177829935 Ah OK, ignore my suggestion to change BlockStoreClient. I don't quite get why it compiled either. but I think an logger in the instance might be correct there. -- This is an automated

[GitHub] [spark] srowen commented on pull request #37058: [SPARK-39661][SQL] Avoid creating unnecessary SLF4J Logger

2022-07-05 Thread GitBox
srowen commented on PR #37058: URL: https://github.com/apache/spark/pull/37058#issuecomment-1175050327 Hm, tests timed out. Can you retrigger? I'm sure it's not related, but good to see tests pass to be sure. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] srowen commented on pull request #37058: [SPARK-39661][SQL] Avoid creating unnecessary SLF4J Logger

2022-07-04 Thread GitBox
srowen commented on PR #37058: URL: https://github.com/apache/spark/pull/37058#issuecomment-1174493537 Same in `BlockStoreClient` - can you change that too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL