[GitHub] [spark] srowen commented on pull request #39250: [SQL][MINOR] Use Diamond operator for constructing HashMap

2022-12-27 Thread GitBox
srowen commented on PR #39250: URL: https://github.com/apache/spark/pull/39250#issuecomment-1366289099 Are there more instances? please fix all at once, if there are more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] srowen commented on pull request #39250: [SQL][MINOR] Use Diamond operator for constructing HashMap

2022-12-27 Thread GitBox
srowen commented on PR #39250: URL: https://github.com/apache/spark/pull/39250#issuecomment-1366299627 OK yeah I ran IJ inspections too. That's the only collection. There is one other related one I think we could fix, in JavaBeanDeserializationSuite : ``` List> expectedRecords

[GitHub] [spark] srowen commented on pull request #39250: [SQL][MINOR] Use Diamond operator for constructing HashMap

2022-12-28 Thread GitBox
srowen commented on PR #39250: URL: https://github.com/apache/spark/pull/39250#issuecomment-1366658285 I think that still generates a compiler warning though, and that's the point of this change. You have to say 'use the inferred generic types'. This PR is about the "<>" syntax in construct

[GitHub] [spark] srowen commented on pull request #39250: [SQL][MINOR] Use Diamond operator for constructing HashMap

2022-12-28 Thread GitBox
srowen commented on PR #39250: URL: https://github.com/apache/spark/pull/39250#issuecomment-1366684112 Yes, though that catches a lot of cases like specifying the generic type explicitly, where "<>" is sufficient. We don't need to 'fix' those, really. They aren't even warnings. -- This i

[GitHub] [spark] srowen commented on pull request #39250: [SQL][MINOR] Use Diamond operator for constructing HashMap

2022-12-29 Thread GitBox
srowen commented on PR #39250: URL: https://github.com/apache/spark/pull/39250#issuecomment-1367348662 Was just waiting for any more feedback. Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab